Re: [PATCH] virDomainDiskDef: Turn @device into enum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/17/2015 11:37 AM, Michal Privoznik wrote:
> It's used as enum everywhere, so why store its value in an int?
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c   | 9 +++------
>  src/conf/domain_conf.h   | 2 +-
>  src/qemu/qemu_command.c  | 2 ++
>  src/vmx/vmx.c            | 6 +++---
>  src/vmx/vmx.h            | 2 +-
>  src/xenconfig/xen_sxpr.c | 4 +++-
>  6 files changed, 13 insertions(+), 12 deletions(-)
> 

Seems reasonable - ACK

John

Seems to be safe too


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]