On 09/24/2015 01:35 AM, Martin Kletzander wrote: > I was playing with coccinelle tool the other day and just for the fun of > it, I tried removing some useless things from our code. And look what > came up. No functional change, and we're down in the number of lines by > about a hundred. It would be worth including your spatch rule in the commit message, for a couple of reasons: If someone tries to backport the patch, having the spatch rule to feed coccinelle will make it easier to replay the rule from scratch instead of having to manually resolve any backport conflicts. Having the ruleset listed lets it be inspected, in case anyone familiar with coccinelle sees a bug in it, or as a teaching moment for those trying to learn coccinelle. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list