Re: [PATCH v3 01/14] migration: refactor: get rid of use_params p2p_full

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 18, 2015 at 18:05:39 +0300, Nikolay Shirokovskiy wrote:
> 'useParams' parameter usage is an example of control coupling. Most of the work
> inside the function is done differently except for the uri check. Lets split
> this function into two, one with extensible parameters set and one with hardcoded
> parameter set.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> ---
>  src/libvirt-domain.c |  103 +++++++++++++++++++++++--------------------------
>  1 files changed, 48 insertions(+), 55 deletions(-)

ACK

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]