Re: [PATCH 4/6] virsh: Resolve Coverity DEADCODE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/24/2015 03:47 AM, Ján Tomko wrote:
> On Wed, Sep 23, 2015 at 07:18:31PM -0400, John Ferlan wrote:
>> Use 'dead_error_condition' instead of 'dead_error_begin'
>>
> 
> Just wondering - what is the difference?

Perhaps just the one condition and not a set of conditions or lines? Not
quite sure, but you know where to find the internal output and you'll
see the data spewed by Coverity about the deadcode.

> Doesn't dead_error_begin require a dead_error_end?

No - once it's dead, it's not coming back to life.

John

> 
>> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
>> ---
>>  tools/virsh.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK.
> 
> Jan
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]