Re: [PATCH] spec: Fix some warnings with latest rpmbuild

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/22/2015 01:57 PM, Cole Robinson wrote:
> $ rpmbuild -ba libvirt.spec
> warning: Macro expanded in comment on line 5: # If neither fedora nor rhel was defined, try to guess them from %{dist}
> 
> warning: Macro %enable_autotools defined but not used within scope
> warning: Macro %client_only defined but not used within scope
> ...
> ---
>  libvirt.spec.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

>  # Default to skipping autoreconf.  Distros can change just this one line
>  # (or provide a command-line override) if they backport any patches that
>  # touch configure.ac or Makefile.am.
> -%{!?enable_autotools:%define enable_autotools 0}
> +%{!?enable_autotools:%global enable_autotools 0}

I guess %global works. I might have tried:

%if !0%{?enable_autotools}
%define enable_autotools 0
%endif

but that's longer.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]