Re: [PATCH] Revert "qemu: Fix integer/boolean logic in qemuSetUnprivSGIO"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 18, 2015 at 03:56:34PM -0400, John Ferlan wrote:
> This reverts commit 69b850fe2a19d0c32ae2f209e8d8463df6ead665.
> 
> This change broke the ability to "clear" or reset unfiltered back
> to filtered.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
> 
> This is a <facepalm> event - have to wonder what I was thinking
> at the time. The patch pushed removes the ability to actually
> clear the value in the file. Although it's possible to check what's
> in the file first, it's still important to "attempt" the check if
> someone set sgio on a disk and unpriv_sgio isn't supported. So, just
> reverting this restores the former functionality of setting to
> either 0 or 1.
> 
>  src/qemu/qemu_conf.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 

ACK

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]