Re: [PATCH v2] test driver: don't unlock pool after freeing it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 17, 2015 at 09:12:31 -0400, David Mansfield wrote:
> 
> 
> On 09/17/2015 01:58 AM, Peter Krempa wrote:
> > On Wed, Sep 16, 2015 at 17:14:28 -0400, David Mansfield wrote:
> 

...

> From 08927d6ff222603e1be2a032c5fed68a5df8c68f Mon Sep 17 00:00:00 2001
> From: David Mansfield <dmansfield@xxxxxxxxx>
> Date: Thu, 17 Sep 2015 08:59:24 -0400
> Subject: [PATCH v2] test driver: don't unlock pool after freeing it
> 
> ---
>  src/test/test_driver.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index 213a9a1..90ab09f 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -4321,6 +4321,7 @@ testStoragePoolUndefine(virStoragePoolPtr pool)
>      }
>  
>      virStoragePoolObjRemove(&privconn->pools, privpool);
> +    privpool = NULL;
>      ret = 0;
>  
>   cleanup:
> -- 
> 2.4.3
> 

ACK and pushed now. I've added a valgrind trace to the commit message.

Thanks for taking time and fixing this.

Peter

(Btw, we usually prefer patch postings via "git send-email" but for
single patches that isn't a big issue and the patch applied just fine).

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]