On 21.09.2015 14:08, John Ferlan wrote: > Similar to commit id '35847860', it's possible to attempt to create > a 'netfs' directory in an NFS root-squash environment which will cause > the 'vol-delete' command to fail. It's also possible error paths from > the 'vol-create' would result in an error to remove a created directory > if the permissions were incorrect (and disallowed root access). > > Thus rename the virFileUnlink to be virFileRemove to match the C API > functionality, adjust the code to following using rmdir or unlink > depending on the path type, and then use/call it for the VIR_STORAGE_VOL_DIR > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/libvirt_private.syms | 2 +- > src/storage/storage_backend_fs.c | 22 ++++++++++------------ > src/util/virfile.c | 29 ++++++++++++++++++++--------- > src/util/virfile.h | 2 +- > 4 files changed, 32 insertions(+), 23 deletions(-) ACK Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list