On Thu, Sep 10, 2015 at 04:20:23PM +0300, Nikolay Shirokovskiy wrote: > Introduce a new function for the check. virDomainMigrateUnmanagedParams is not > a good candidate for this functionality as it is used by migrate family > functions too and its have its own checks that are superset of extracted and we > don't need to check twice. > > Actually name of the function is slightly misleading as there is also a check > for consitensy of flags parameter alone. So it could be refactored further and > reused by all migrate functions bu for now let it be a matter of a different > patchset. > > It is *not* a pure refactoring patch as it introduces offline check for all > versions. Looks like it must be done that way and no one will be broken too. > > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx> > --- > src/libvirt-domain.c | 81 +++++++++++++++++++------------------------------ > 1 files changed, 32 insertions(+), 49 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list