On Thu, Sep 17, 2015 at 10:28:02AM +0200, Matthias Bolte wrote: > 2015-09-16 10:47 GMT+02:00 Richard W.M. Jones <rjones@xxxxxxxxxx>: > > On Fri, Sep 11, 2015 at 03:55:03PM +0200, Matthias Bolte wrote: > >> 2015-09-07 22:04 GMT+02:00 Richard W.M. Jones <rjones@xxxxxxxxxx>: > >> > On Mon, Sep 07, 2015 at 02:29:22PM +0200, Matthias Bolte wrote: > >> >> I think the datacenter path could be exposed > >> >> as part of the domain XML as > >> >> <vmware:datacenterpath>/path/to/dc</vmware:datacenterpath> similar to > >> >> the way <qemu:commandline> works. But it would be ignored on parsing. > >> >> > >> >> Would that work for you? If yes, I can propose a patch that does this. > >> > > >> > Absolutely this would be brilliant. > >> > >> Okay, here's patch that does this. It's only tested using the test > >> suite, as I don't have an ESX setup at hand at the moment. Do you have > >> the possibility to test this properly? > > > >> From 489e2d5dd29dd4b11716897ca52b14f6666ec141 Mon Sep 17 00:00:00 2001 > >> From: Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx> > >> Date: Fri, 11 Sep 2015 12:00:47 +0200 > >> Subject: [PATCH] vmx: Expose datacenter path in domain XML > > > > If you're happy with this patch, I'd like to push it to the libvirt > > repo. I didn't see any later version on the list. Let me know if > > this is the final version. > > > > Also I have opened a BZ for the problem so the fix can be included in > > RHEL 7.3: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1263574 > > Regarding your question about the changes to the VMware driver: The > only required change is the addition for "ctx.datacenterPath = NULL" > where virVMXParseConfig is called. The other additions are not really > necessary. I made them for the sake of completeness and to match the > usage in the ESX driver. > > Overall I'm happy with this patch. The only concern I have is that the > domain XML might not be quite the right place to expose this > information. But there are not many other places to expose this > without adding new public API. But I assume that the domain XML is the > most convenient was for libguestfs to get this information, isn't it? We can get it from anywhere as long as it's in the XML. Let's wait for a second review, and if that is ACKed then I will push it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list