Hello! > Well, without your patch, I get a clear message for non-arm > (e.g. x86_64) machine that says "virtio disk cannot have an address of > type 'virtio-mmio'" (even though I have en_GB locale in which the > string should be very badly translated, but that's another problem). > And that is what we should keep for architectures without virtio-mmio > support, shouldn't we? Agree, thanks for testing. I don't have x86 installation here. I will make v2 which will check for QEMU_CAPS_DEVICE_VIRTIO_MMIO capability. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list