Re: [PATCH 1/2] qemuProcessStart: Parse backingStore for all disks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 08, 2015 at 17:17:18 +0200, Michal Privoznik wrote:

Subject is misleading. Backing store is detected from disk images not
parsed from XML.

> Later, in the next commit, we are going to need backing chain
> for all the disks within the domain. Let's parse them at domain
> startup phase.

Why do we need this patch? Currently qemuDomainDetermineDiskChain still
gets called on all disks where it makes sense. Exceptions are:
1) empty drives (this is also redundant, since
qemuDomainDetermineDiskChain will check it again).

2) disk source formats that don't support backing chains, where we just
check that the file exists.

This patch would make us call that on those too.

NACK,

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]