Re: [PATCH] conf: fix crash when parse a disordered numa settings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/08/2015 04:40 PM, Michal Privoznik wrote:
On 08.09.2015 06:59, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1260846

Introduced by 8fedbbdb, if we parse the disordered numa
cell, will get segfault. This is because we allow parse
the numa cell not in order and we alloc them before the
parse loop, the cpumask maybe NULL when parse each numa
cell.

Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx>
---
  src/conf/numa_conf.c                               | 10 +++++---
  .../qemuxml2argv-cpu-numa-disordered.xml           | 26 +++++++++++++++++++
  .../qemuxml2xmlout-cpu-numa-disordered.xml         | 29 ++++++++++++++++++++++
  tests/qemuxml2xmltest.c                            |  1 +
  4 files changed, 63 insertions(+), 3 deletions(-)
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-numa-disordered.xml
  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-numa-disordered.xml
I've reworded the commit message a bit, ACKed and pushed.

Thanks a lot for your quick review and help.

Michal

Luyao

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]