2015-09-02 13:00 GMT+02:00 Michal Privoznik <mprivozn@xxxxxxxxxx>: > On 01.09.2015 16:52, Matthias Bolte wrote: >> This patch series addresses this bug report: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1172544 >> >> It's mean as a replacement for this patch: >> >> https://www.redhat.com/archives/libvir-list/2015-August/msg00970.html >> >> >> Matthias Bolte (3): >> vmx: Some whitespace cleanup >> vmx: The virVMXParseDisk deviceType can be NULL, add some missing >> checks >> vmx: Add handling for CDROM devices with SCSI passthru >> >> src/vmx/vmx.c | 81 ++++++++++++++------- >> tests/vmx2xmldata/vmx2xml-cdrom-scsi-passthru.vmx | 6 ++ >> tests/vmx2xmldata/vmx2xml-cdrom-scsi-passthru.xml | 24 +++++++ >> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-7.vmx | 85 +++++++++++++++++++++++ >> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-7.xml | 35 ++++++++++ >> tests/vmx2xmltest.c | 2 + >> tests/xml2vmxdata/xml2vmx-cdrom-scsi-passthru.vmx | 14 ++++ >> tests/xml2vmxdata/xml2vmx-cdrom-scsi-passthru.xml | 14 ++++ >> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-7.vmx | 25 +++++++ >> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-7.xml | 35 ++++++++++ >> tests/xml2vmxtest.c | 2 + >> 11 files changed, 296 insertions(+), 27 deletions(-) >> create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-passthru.vmx >> create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-passthru.xml >> create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-7.vmx >> create mode 100644 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-7.xml >> create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-passthru.vmx >> create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-passthru.xml >> create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-7.vmx >> create mode 100644 tests/xml2vmxdata/xml2vmx-esx-in-the-wild-7.xml >> > > ACK series if you fix the small nit in 2/3. Fixed and pushed, thanks. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list