Re: [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/03/2015 01:40 PM, Jim Fehlig wrote:
> Remove redundant error reporting in libxlDomainMigrationPerform().
> virNetSocketNewConnectTCP() is perfectly capable of reporting
> sensible errors.
> 
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
> 
> V2:
> Actually try to compile the code and find saved_errno is no
> longer used - remove it.
> 
>  src/libxl/libxl_migration.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 

ACK

John

Also noteworthy that virNetSocketNewConnectTCP could overwrite errno
when freeaddrinfo is run in error: or when VIR_FORCE_CLOSE() did it's
thing...

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]