On Thu, Feb 05, 2009 at 08:16:57PM +0000, Daniel P. Berrange wrote: > On Thu, Feb 05, 2009 at 11:27:19AM -0800, john.levon@xxxxxxx wrote: > > # HG changeset patch > > # User john.levon@xxxxxxx > > # Date 1233859424 28800 > > # Node ID dd8a1923aae38d9e36cb98a934af64450ecd85a2 > > # Parent 8086732c0e4250d26a4cfed2411e86b209712eb5 > > Introduce virCopyLastError() > > > > Allow applications to store a copy of the last error reported. > > > > Signed-off-by: John Levon <john.levon@xxxxxxx> > > ACK, though in the comment for virSaveLastError can you add > an explicit note saying the caller must use virResetError > to release memory associated with the virErrorPtr object > once done. Actually, I see virResetError doesn't actually free the virErrorPtr itself, only the strings within it. Looks like we might want to have a virErrorFree() API to go along with it Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list