Hi, On Mon, Aug 31, 2015 at 04:06:18PM -0400, Jonathan Toppins wrote: > On 08/31/2015 03:25 PM, Guido Günther wrote: > >Hi, > >On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: > >>Adds a new interface type using UDP sockets, this seems only applicable > >>to QEMU but have edited tree-wide to support the new interface type. > >> > >>The interface type required the addition of a "localaddr" (local > >>address), this then maps into the following xml and qemu call. > >> > >><interface type='udp'> > > > > > >Sine we do have > > > > <interface type='mcast'> > > > >already wouldn't it be better to have something like > > > > <interface type='ucast' protocol='udp'> > > > > This possibly could be better, my concern would be now tcp is configured > differently than udp, no? Or are you saying something like: tcp client/server is configured with <interface type='server'> atm which fits as well. That said I don't have a strong opinion on that one. > <interface type='ucast' protocol='udp|tcp'> > > My concern here is this would be a bigger change and does libvirt have a > stable xml configuration guarantee? XML of older lbvirt must be parseable by newer ones, yes. Cheers, -- Guido -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list