Re: [PATCH V2 1/3] libxl: fix ref counting of libxlMigrationDstArgs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michal Privoznik wrote:
> On 27.08.2015 23:38, Jim Fehlig wrote:
>   
>> How does it look with the following squashed in?
>>
>> diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c
>> index 8db3aea..9609e06 100644
>> --- a/src/libxl/libxl_migration.c
>> +++ b/src/libxl/libxl_migration.c
>> @@ -112,9 +112,9 @@ libxlDoMigrateReceive(void *opaque)
>>  
>>      /* Remove all listen socks from event handler, and close them. */
>>      for (i = 0; i < nsocks; i++) {
>> -        virNetSocketUpdateIOCallback(socks[i], 0);
>>          virNetSocketRemoveIOCallback(socks[i]);
>>          virNetSocketClose(socks[i]);
>> +        virObjectUnref(socks[i]);
>>          socks[i] = NULL;
>>      }
>>      args->nsocks = 0;
>>
>>     
>
>
> Yup, with this piece it looks good. ACK
> Er, we are currently in a freeze, but after all: a) this is a bugfix, b)
> this has been sitting on the list quite a while. So I'd say push it.
>   

Thanks. Series pushed.

Regards,
Jim

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]