2015-08-24 14:56 GMT+03:00 Vasiliy Tolstov <v.tolstov@xxxxxxxxx>: > 2015-08-24 14:45 GMT+03:00 Laine Stump <laine@xxxxxxxxx>: >> I've been looking back at the history of why this code was added in the >> first place to make sure we're not inadvertently breaking something else. >> >> It looks like originally that code did check that ipaddr hadn't changed >> (when there was a single IP address), which wasn't needed but also >> didn't hurt anything (since ipaddr would always be 0 for type='ethernet' >> in the qemu driver. Then recently (commit aa2cc7) support for multiple >> IP addresses with type='ethernet' was added (apparently for LXC, but >> also added for openvz), any code that had touched ethernet.ipaddr was >> changed to look at nips and the ip array instead, but the code that >> replaced the unnecessary but innocuous check in qemu_hotplug.c was done >> incorrectly. So the correct thing *is* to simply remove the check. >> >> All of that is a long winded way of saying ACK. I'll push it in awhile. > > > Thanks! I don't see this change in current master. Does it goes to 1.2.19 or to 1.2.20? -- Vasiliy Tolstov, e-mail: v.tolstov@xxxxxxxxx -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list