On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote:
So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definition is updated. After that, old domain name is removed from the domain object list. Now, if the very firs step fails for some reason, no
Well, the problem here is that the first step can fail for 2 reasons. One of them is that the domain already exists, the second one is an OOM error. What's even worse is that the OOM error gets reported, but the duplicate key error doesn't. There should be either a hint for the user that domain with such name already exists or that should be checked right before. The second variant would not be race-free, but there would be only a small window of opportunity left. The con would be that you won't report "already exists" error when there's an OOM error already. Checking for that error seems too weird, it would be more worth fixing the has table implementation we have :)
error is reported:
virsh # domrename dummy dummy
error: An error occurred, but the cause is unknown
Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
src/qemu/qemu_driver.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3683591..8e365bd 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -19950,8 +19950,11 @@ static int qemuDomainRename(virDomainPtr dom,
goto endjob;
}
- if (virDomainObjListRenameAddNew(driver->domains, vm, new_name) < 0)
+ if (virDomainObjListRenameAddNew(driver->domains, vm, new_name) < 0) {
+ virReportError(VIR_ERR_OPERATION_FAILED, "%s",
+ _("could not add new name into internal list of domains"));
goto endjob;
+ }
if ((logfile = qemuDomainCreateLog(driver, vm, true)) < 0)
goto rollback;
--
2.4.6
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list