Re: [PATCH 4/9] Add newDomain parameter to qemuDomainAssignAddresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/12/2015 10:52 AM, Ján Tomko wrote:
> To differentiate a new domain from an existing one.
> ---
>  src/qemu/qemu_command.c  |  5 ++++-
>  src/qemu/qemu_command.h  |  3 ++-
>  src/qemu/qemu_driver.c   | 22 +++++++++++-----------
>  src/qemu/qemu_process.c  |  6 +++---
>  tests/qemuhotplugtest.c  |  2 +-
>  tests/qemuxml2argvtest.c |  2 +-
>  tests/qemuxmlnstest.c    |  2 +-
>  7 files changed, 23 insertions(+), 19 deletions(-)
> 

Could have used a slightly beefier commit message...

I've looked ahead and see how it's used and it seems OK - although it's
too bad we couldn't have some way to know in the domain def to know this
domain has never been defined/created *and* saved in some manner. This
certainly works, just was thinking of a way to avoid another parameter
and perhaps a way that could be extensible in the future

ACK to what's here - unless this causes someone to think of something
different.

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]