Re: [PATCH 2/9] Remove unused virDomainVirtioSerialAddrSetRemoveController

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/12/2015 10:52 AM, Ján Tomko wrote:
> This function was never used.
> 

I think that portion could have been removed in 1/9 since that's when
you removed the unreachable 'external' call to it.

> Also mark virDomainVirtioSerialAddrSetAddController as static.

And this just becomes 2/9


> ---
>  src/conf/domain_addr.c   | 23 +----------------------
>  src/conf/domain_addr.h   |  8 --------
>  src/libvirt_private.syms |  2 --
>  3 files changed, 1 insertion(+), 32 deletions(-)
> 

But I understand why it's easier to do it one patch...

ACK,

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]