The comment for the function indicated that iothread_id had to be a positive non-zero value; however, that wasn't checked - that is a value of 0 is/was allowed by the API and was left up to the hypervisor to reject the value. More than likely this nuance was missed during the many "adjustments" to the API in the review phase. Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> --- src/libvirt-domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 9ec66df..405962d 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -7952,9 +7952,9 @@ virDomainPinIOThread(virDomainPtr domain, * @iothread_id: the specific IOThread ID value to add * @flags: bitwise-OR of virDomainModificationImpact * - * Dynamically add an IOThread to the domain. If @iothread_id is a positive - * non-zero value, then attempt to add the specific IOThread ID and error - * out if the iothread id already exists. + * Dynamically add an IOThread to the domain. It is left up to the + * underlying virtual hypervisor to determine the valid range for an + * @iothread_id and determining whether the @iothread_id already exists. * * Note that this call can fail if the underlying virtualization hypervisor * does not support it or if growing the number is arbitrarily limited. -- 2.1.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list