On 08/11/2015 03:57 PM, John Ferlan wrote: > > On 08/11/2015 03:03 PM, Laine Stump wrote: >> Commit e8d5517 updated the domain post-parse to automatically add >> pcie-root et al for certain ARM "virt" machinetypes, but didn't update >> the function qemuDomainSupportsPCI() which is called later on when we >> are auto-assigning PCI addresses and default settings for the PCI >> controller <model> and <target> attributes. The result was that PCI >> addresses weren't assigned, and the controllers didn't have their >> attribute default values set, leading to an error when the domain was >> started, e.g.: >> >> internal error: autogenerated dmi-to-pci-bridge options not set >> >> This patch duplicates the check made in the earlier patch, so that PCI >> address auto-assignment and target/model default values will be set. >> --- >> >> The example Cole gave in his email reporting this bug is fixed by this >> patch. >> >> src/qemu/qemu_command.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> > ACK > > John > > It's very tangled web... Yep. troubling but probably unavoidable given what we're working with. > Perhaps an additional comment to point at > qemuDomainSupportsPCI in qemu_domain.c just before the "if > (addPCIeRoot)" may help future changes that could trip into the same > rabbit hole... Okay, I did that and pushed it. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list