Re: [PATCH 8/9] virsh: Implement VIR_DOMAIN_BANDWIDTH_IN_FLOOR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/11/2015 06:08 AM, Michal Privoznik wrote:
> On 11.08.2015 03:25, John Ferlan wrote:
>>
>>
>> On 08/03/2015 02:39 AM, Michal Privoznik wrote:
>>> We have a function parseRateStr() that parses --inbound and
>>> --outbound arguments to both attach-interface and domiftune.
>>> Now that we have all virTypedParams macros needed for QoS,
>>> lets parse even floor attribute. The extended format for the
>>> arguments looks like this then:
>>>
>>>   --inbound average[,peak[,burst[,floor]]]
>>>
>>> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
>>> ---
>>>  tools/virsh-domain.c | 23 ++++++++++++++++++-----
>>>  tools/virsh.pod      | 12 ++++++------
>>>  2 files changed, 24 insertions(+), 11 deletions(-)
>>>

ACK with the squashed in code - now it makes more sense too ;-) (both
because of the extra comments/code and some sleep)

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]