Re: [PATCH 3/6] admin: Drop 'internal.h' include from libvirt-admin.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 11, 2015 at 09:58:58AM +0200, Erik Skultety wrote:
This is a public library, it shouldn't include anything that is
internal. Including the library in it's current state to an example
application fails the preprocessor phase.
---
include/libvirt/libvirt-admin.h | 2 --
1 file changed, 2 deletions(-)


ACK as-is (independent of other patches, feel free to push this ASAP.

diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h
index b3cfc93..9997cc2 100644
--- a/include/libvirt/libvirt-admin.h
+++ b/include/libvirt/libvirt-admin.h
@@ -26,8 +26,6 @@
#ifndef __VIR_ADMIN_H__
# define __VIR_ADMIN_H__

-# include "internal.h"
-
# ifdef __cplusplus
extern "C" {
# endif
--
2.4.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]