Re: [PATCH 1/9] virNetDevParseMcast: Avoid magic constant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/03/2015 02:39 AM, Michal Privoznik wrote:
> There is no guarantee that an enum start it mapped onto a value
> of zero. However, we are guaranteed that enum items are
> consecutive integers. Moreover, it's a pity to define an enum to
> avoid using magical constants but then using them anyway.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/util/virnetdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

ACK

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]