Re: [PATCH] virNetDevBandwidthParseRate: Reject negative values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 07, 2015 at 05:12:12PM +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1022292
> 
> The following XML really does not make any sense:
> 
> <inbound average="-1" burst="-2" peak="-3" floor="-4"/>
> 
> There can't be a negative packet rate. Well, so far we haven't
> assigned any meaning to it. So reject it unless users harm themselves,
> because otherwise we turn the negative numbers into really big values.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/conf/netdev_bandwidth_conf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

ACK,

would be nicer with a test case.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]