On Mon, Feb 02, 2009 at 06:08:17PM +0100, Jim Meyering wrote:
> From: Jim Meyering <meyering@xxxxxxxxxx>
>
> * src/iptables.c: Include "virterror_internal.h".
> Use virStrerror, not strerror.
> * src/virterror.c (virStrerror): Remove "static".
> * src/virterror_internal.h (virStrerror): Declare it.
> ---
> src/iptables.c | 25 ++++++++++++++++---------
> src/virterror.c | 2 +-
> src/virterror_internal.h | 3 ++-
> 3 files changed, 19 insertions(+), 11 deletions(-)
> diff --git a/src/virterror.c b/src/virterror.c
> index 160fea3..6c479f4 100644
> --- a/src/virterror.c
> +++ b/src/virterror.c
> @@ -1005,7 +1005,7 @@ void virReportErrorHelper(virConnectPtr conn, int domcode, int errcode,
>
> }
>
> -static const char *virStrerror(int theerrno, char *errBuf, size_t errBufLen)
> +const char *virStrerror(int theerrno, char *errBuf, size_t errBufLen)
> {
> #ifdef HAVE_STRERROR_R
> # ifdef __USE_GNU
> diff --git a/src/virterror_internal.h b/src/virterror_internal.h
> index 3a11705..709c8ec 100644
> --- a/src/virterror_internal.h
> +++ b/src/virterror_internal.h
> @@ -1,7 +1,7 @@
> /*
> * virterror.h: internal error handling
> *
> - * Copyright (C) 2006-2008 Red Hat, Inc.
> + * Copyright (C) 2006-2009 Red Hat, Inc.
> *
> * This library is free software; you can redistribute it and/or
> * modify it under the terms of the GNU Lesser General Public
> @@ -81,5 +81,6 @@ void virReportOOMErrorFull(virConnectPtr conn,
>
> void virSetGlobalError(void);
> void virSetConnError(virConnectPtr conn);
> +const char *virStrerror(int theerrno, char *errBuf, size_t errBufLen);
This seems to be missing ta change to libvirt_private.sym to actually
export the new function to individual drivers.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list