On Thu, 2015-08-06 at 13:20 +0200, Jiri Denemark wrote: > > > static void > > +ppc64DataFree(virCPUppc64Data *data) > > +{ > > + if (!data) > > + return; > > This is redundant unless you want to add more fields in the structure > which will need to be freed here. > > > + > > + VIR_FREE(data); > > +} I'm adding the fields in the next commit, but I can just move the check to that commit as well :) Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list