On 07/22/2015 10:54 AM, John Ferlan wrote: > v1 here: > http://www.redhat.com/archives/libvir-list/2015-June/msg01104.html > > Some followups into July resulted in the request to move the Hostdev > and Disk default (or _NONE) address creation/assignment into domain/ > device post processing rather than during XML parsing. > > Changes in v2 are numerous, quite a bit of patch and code motion in order > to accomplish the requested task in small enough and reviewable chunks > > John Ferlan (12): > conf: Remove extraneous check in virDomainHostdevAssignAddress > conf: Add 'bus' and 'target' to SCSI address conflict checks > conf: Move hostdev and disk address validations > conf: Add xmlopt to virDomainDeviceDefPostParseInternal > conf: Add check for host address type while checking in use > conf: Try controller add when searching hostdev bus for unit > conf: Change when virDomainHostdevAssignAddress is called > conf: Remove unused param from virDomainHostdevDefParseXML > conf: Add SCSI hostdev check for disk drive address already in use > conf: Change when virDomainDiskDefAssignAddress is called > conf: Create locals for virDomainDiskDefAssignAddress > conf: Check for hostdev conflicts when assign default disk address > > docs/formatdomain.html.in | 4 +- > src/conf/domain_conf.c | 396 +++++++++++++++++++++++++++------------------- > src/conf/domain_conf.h | 3 +- > src/qemu/qemu_command.c | 4 +- > src/vmx/vmx.c | 22 +-- > src/vmx/vmx.h | 3 +- > 6 files changed, 253 insertions(+), 179 deletions(-) > I fixed the error message in patch 7 and pushed patches 1-8 and 10. Adjustments to the other patches will take a bit more time and testing - I don't think throwing away the existing patches will completely work for the hotplug cases. It's been a few weeks since I had this all fresh in my mind though. John I'll rework and post the duplicate address check -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list