On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote:
> PowerPC pseries based VMs do not support a floppy disk controller.
Here the commit message mentions a controller, but the code only checks
for the <disk type='floppy'/> device,
not for <controller type='fdc'/>
Should we forbid that one too? AFAIK we've auto-added it to the XML
only if there was at least floppy.
Either way, the series looks good to me.
Jan
> This prohibits libvirt from creating qemu command with floppy device.
>
> Signed-off-by: Kothapally Madhu Pavan <kmp@xxxxxxxxxxxxxxxxxx>
> ---
> src/qemu/qemu_command.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 09f30c4..501c7df 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -9767,6 +9767,14 @@ qemuBuildCommandLine(virConnectPtr conn,
> continue;
> }
>
> + /* PowerPC pseries based VMs do not support floppy device */
> + if ((disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) &&
> + ARCH_IS_PPC64(def->os.arch) && STRPREFIX(def->os.machine, "pseries")) {
> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("PowerPC pseries machines do not support floppy device"));
> + goto error;
> + }
> +
> switch (disk->device) {
> case VIR_DOMAIN_DISK_DEVICE_CDROM:
> bootindex = bootCD;
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list