On Thu, 2015-07-30 at 10:05 +0200, Peter Krempa wrote: > On Thu, Jul 30, 2015 at 09:51:15 +0200, Andrea Bolognani wrote: > > On Thu, 2015-07-30 at 09:45 +0200, Peter Krempa wrote: > > > > > > Since we know that here we are trying to set 0 cpus which is > > > wrong we > > > can also say that explicitly in the error message rather than > > > copying > > > the generic one. > > > > Using the generic one means we don't have to add yet another > > translatable string, though. Or did you mean to use a > > completely different error message? > > Completely different. Something along: "Can't set 0 processors for a > VM" I see. I don't feel strongly either way, I just want to avoid having a bunch of very similar but non-identical messages; if you feel a custom error message is warranted in this situation then go right ahead. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list