Re: [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/20/2015 09:28 AM, Olaf Hering wrote:
On Thu, Jul 16, Jim Fehlig wrote:

@@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn,
          virObjectUnref(socks[i]);
      }
      VIR_FREE(socks);
+    virObjectUnref(args);
This is now below the 'error' label, so args has to be initialized.

[  149s] libxl/libxl_migration.c: In function 'libxlDomainMigrationPrepare':
[  149s] libxl/libxl_migration.c:463:19: warning: 'args' may be used uninitialized in this function [-Wmaybe-uninitialized]
[  149s]      virObjectUnref(args);
[  149s]                    ^

Opps. I've squashed in the below obvious fix. Note it is safe to call virObjectUnref with a NULL object.

Any other comments on this series? It fixes bugs in migration, including a possible libvirtd crash, and would be a candidate to push during freeze IMO.

Regards,
Jim

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]