Re: [PATCH] qemu: Check for iotune_max support properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 27, 2015 at 08:30:16AM +0200, Martin Kletzander wrote:
> Commit d506a51aeb2a7a7b0c963f760e32b94376ea7173 meant to check for
> QEMU_CAPS_DRIVE_IOTUNE_MAX, but checked for QEMU_CAPS_DRIVE_IOTUNE
> instead.  That's clearly visible from the diff, but it got in.  Because
> of that, we were supplying information unknown for QEMU if it wasn't new
> enough and we couldn't even properly handle the error, leading to
> "Unexpected error".  Also iops_size came at the same time with all the
> other "_max" options, so check whether we're not setting that either if
> QEMU_CAPS_DRIVE_IOTUNE_MAX is not supported.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1224053
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

ACK

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]