On 07/17/2015 02:43 PM, Laine Stump wrote:
> This is backed by the qemu device xio3130-downstream. It can only be
> connected to a pcie-switch-upstream-port (x3130-upstream) on the
> upstream side.
> ---
> V2:
>
> * change test case to reflect additional pcie-root-port between
> pcie-root and pcie-switch-upstream-port and add a 2nd switch that is
> connected to a downstream port of the 1st switch.
>
> src/qemu/qemu_command.c | 42 ++++++++++++++++++++++
> .../qemuxml2argv-pcie-switch-downstream-port.args | 18 ++++++++++
> tests/qemuxml2argvtest.c | 9 +++++
> 3 files changed, 69 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.args
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index e3f0663..155a94a 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -1610,6 +1610,12 @@ qemuCollectPCIAddress(virDomainDefPtr def ATTRIBUTE_UNUSED,
> */
> flags = VIR_PCI_CONNECT_TYPE_PCIE_PORT;
> break;
> + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_DOWNSTREAM_PORT:
> + /* pcie-switch-downstream-port can only connect to a
> + * pcie-switch-upstream-port, and can't be hot-plugged.
> + */
> + flags = VIR_PCI_CONNECT_TYPE_PCIE_SWITCH;
> + break;
> default:
> break;
> }
> @@ -2292,6 +2298,13 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def,
> deviceName = "x3130-upstream";
> break;
> case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_DOWNSTREAM_PORT:
> + if (!options->type)
> + deviceName = "xio3130-downstream";
> + if (options->chassis == -1)
> + options->chassis = cont->idx;
> + if (options->port == -1)
> + options->port = addr->slot;
> + break;
> case VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT:
> case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT:
> case VIR_DOMAIN_CONTROLLER_MODEL_PCI_LAST:
> @@ -2416,6 +2429,10 @@ qemuAssignDevicePCISlots(virDomainDefPtr def,
> */
> flags = VIR_PCI_CONNECT_TYPE_PCIE_PORT;
> break;
> + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_DOWNSTREAM_PORT:
> + /* pcie-switch-port can only plug into pcie-switch */
> + flags = VIR_PCI_CONNECT_TYPE_PCIE_SWITCH;
> + break;
> default:
> flags = VIR_PCI_CONNECT_HOTPLUGGABLE | VIR_PCI_CONNECT_TYPE_PCI;
> break;
> @@ -4766,6 +4783,31 @@ qemuBuildControllerDevStr(virDomainDefPtr domainDef,
> virBufferAsprintf(&buf, "%s,id=%s",
> def->opts.pciopts.type, def->info.alias);
> break;
> + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_DOWNSTREAM_PORT:
> + if (!def->opts.pciopts.type) {
> + virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> + _("autogenerated pcie-switch-downstream-port "
> + "options not set"));
> + goto error;
> + }
> + if (STREQ(def->opts.pciopts.type, "xio3130-downstream")) {
> + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_XIO3130_DOWNSTREAM)) {
> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("The pcie-switch-downstream-port "
> + "(xio3130-downstream) controller "
> + "is not supported in this QEMU binary"));
> + goto error;
> + }
> + } else {
> + virReportError(VIR_ERR_INTERNAL_ERROR,
> + _("unknown pcie-switch-downstream-port device '%s'"),
similar to previous
unknown pci-switch-downstream-port option model '%s'
Of course perhaps all solveable by the enum type rather than string.
John
> + def->opts.pciopts.type);
> + goto error;
> + }
> + virBufferAsprintf(&buf, "%s,port=0x%x,chassis=%d,id=%s",
> + def->opts.pciopts.type, def->opts.pciopts.port,
> + def->opts.pciopts.chassis, def->info.alias);
> + break;
> }
> break;
>
> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.args b/tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.args
> new file mode 100644
> index 0000000..fefefa2
> --- /dev/null
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.args
> @@ -0,0 +1,18 @@
> +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
> +/usr/libexec/qemu-kvm -S -M q35 -m 2048 -smp 2 -nographic -nodefaults \
> +-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c \
> +-device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
> +-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
> +-device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \
> +-device x3130-upstream,id=pci.4,bus=pci.3,addr=0x0 \
> +-device xio3130-downstream,port=0x0,chassis=5,id=pci.5,bus=pci.4,addr=0x0 \
> +-device xio3130-downstream,port=0x1,chassis=6,id=pci.6,bus=pci.4,addr=0x1 \
> +-device xio3130-downstream,port=0x2,chassis=7,id=pci.7,bus=pci.4,addr=0x2 \
> +-device xio3130-downstream,port=0x27,chassis=30,id=pci.8,bus=pci.4,addr=0x3 \
> +-device x3130-upstream,id=pci.9,bus=pci.5,addr=0x0 \
> +-device xio3130-downstream,port=0x4,chassis=10,id=pci.10,bus=pci.4,addr=0x4 \
> +-device xio3130-downstream,port=0x5,chassis=11,id=pci.11,bus=pci.4,addr=0x5 \
> +-device xio3130-downstream,port=0x6,chassis=12,id=pci.12,bus=pci.4,addr=0x6 \
> +-drive file=/dev/HostVG/QEMUGuest1,if=none,id=drive-sata0-0-0 \
> +-device ide-drive,bus=ide.0,drive=drive-sata0-0-0,id=sata0-0-0 \
> +-vga qxl -global qxl-vga.ram_size=67108864 -global qxl-vga.vram_size=33554432
> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
> index b42d483..287df6a 100644
> --- a/tests/qemuxml2argvtest.c
> +++ b/tests/qemuxml2argvtest.c
> @@ -1512,6 +1512,15 @@ mymain(void)
> QEMU_CAPS_DRIVE, QEMU_CAPS_ICH9_AHCI,
> QEMU_CAPS_VGA, QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
> QEMU_CAPS_VGA, QEMU_CAPS_VGA_QXL, QEMU_CAPS_DEVICE_QXL);
> + DO_TEST("pcie-switch-downstream-port",
> + QEMU_CAPS_DEVICE, QEMU_CAPS_DEVICE_PCI_BRIDGE,
> + QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE,
> + QEMU_CAPS_DEVICE_IOH3420,
> + QEMU_CAPS_DEVICE_X3130_UPSTREAM,
> + QEMU_CAPS_DEVICE_XIO3130_DOWNSTREAM,
> + QEMU_CAPS_DRIVE, QEMU_CAPS_ICH9_AHCI,
> + QEMU_CAPS_VGA, QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
> + QEMU_CAPS_VGA, QEMU_CAPS_VGA_QXL, QEMU_CAPS_DEVICE_QXL);
>
> DO_TEST("hostdev-scsi-lsi", QEMU_CAPS_DRIVE,
> QEMU_CAPS_DEVICE, QEMU_CAPS_DRIVE,
>
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list