On 07/17/2015 02:43 PM, Laine Stump wrote: > This loop occurs just after we've assured that all devices that > require a PCI device have been assigned and all necessary PCI > controllers have been added. It is the perfect place to add other > potentially auto-generated PCI controller attributes that are > dependent on the controller's PCI address (upcoming patch). > > There is a convenient loop through all controllers at the end of the > function, but the patch to add new functionality will be cleaner if we > first rearrange that loop a bit. > > Note that the loop originally was accessing info.addr.pci.bus prior to > determining that the pci part of the object was valid. This isn't > dangerous in any way, but seemed a bit ugly, so I fixed it. > --- > new in V2 > > src/qemu/qemu_command.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > ACK John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list