Re: [PATCHv2 01/17] conf: reorganize virNetworkDHCPDefParseXML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/17/2015 02:43 PM, Laine Stump wrote:
> This makes the range and static host array management in
> virNetworkDHCPDefParseXML() more similar to what is done in
> virNetworkDefUpdateIPDHCPRange() and virNetworkDefUpdateIPDHCPHost() -
> they use VIR_APPEND_ELEMENT rather than a combination of
> VIR_REALLOC_N() and separate incrementing of the array size.
> 
> The one functional change here is that a memory leak of the contents
> of the last (unsuccessful) virNetworkDHCPHostDef was previously leaked
> in certain failure conditions, but it is now properly cleaned up.
> ---
> 
> new in V2
> 
>  src/conf/network_conf.c | 36 +++++++++++++++++++-----------------
>  1 file changed, 19 insertions(+), 17 deletions(-)
>
ACK

John


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]