On Fri, Jan 30, 2009 at 08:07:53PM +0100, Jim Meyering wrote:
> John Levon <levon@xxxxxxxxxxxxxxxxx> wrote:
> > 17) QEMU XML-2-ARGV disk-drive-shared ... FAILED
> >
> > I have VIR_TEST_DEBUG set, but this is all I get. It's new
>
> The test failure affects all systems, since
> two newly required test files were not committed:
>
> tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args
> tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
Sorry about that mistake. Rule #1: never commit stuff at the
end of a Friday afternoon :-) Added the two missing test files
now.
> >From 560e27e1576a4c0ebe7db3e697ed9b6d8aa88fbc Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@xxxxxxxxxx>
> Date: Fri, 30 Jan 2009 20:06:48 +0100
> Subject: [PATCH] tests: diagnose open failure
>
> * tests/qemuxml2argvtest.c (testCompareXMLToArgvFiles): Diagnose
> failure to open an input file.
> ---
> tests/qemuxml2argvtest.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
> index 90b4740..1d7aeb9 100644
> --- a/tests/qemuxml2argvtest.c
> +++ b/tests/qemuxml2argvtest.c
> @@ -36,8 +36,10 @@ static int testCompareXMLToArgvFiles(const char *xml,
> virDomainDefPtr vmdef = NULL;
> virDomainObj vm;
>
> - if (virtTestLoadFile(cmd, &expectargv, MAX_FILE) < 0)
> + if (virtTestLoadFile(cmd, &expectargv, MAX_FILE) < 0) {
> + fprintf(stderr, "failed to open %s: %s\n", cmd, strerror (errno));
> goto fail;
> + }
>
> if (!(vmdef = virDomainDefParseFile(NULL, driver.caps, xml,
> VIR_DOMAIN_XML_INACTIVE)))
ACK
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list