Re: [PATCH] configure: clarify rationale for checking pkcheck

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/21/2015 10:53 AM, Daniel P. Berrange wrote:
> We don't need pkcheck binary, but we must detect it in order
> to see if we're preferring polkit-1 over polkit-0 when both
> are installed. We should also check $with_dbus to see if we
> have dbus-devel available, as that's required to talk to
> polkit-1.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  configure.ac | 27 ++++++++++++++++++++-------
>  1 file changed, 20 insertions(+), 7 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 70b3ef3..db0ccd1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1339,15 +1339,28 @@ AC_ARG_WITH([polkit],
>  with_polkit0=no
>  with_polkit1=no
>  if test "x$with_polkit" = "xyes" || test "x$with_polkit" = "xcheck"; then
> -  dnl Check for new polkit first - just a binary
> +  dnl Check for new polkit first. We directly talk over DBus
> +  dnl but we use existance of pkcheck binary as a sign that

s/existance/existence/

ACK with that fix.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]