On 07/17/2015 10:15 AM, Daniel P. Berrange wrote:
> On Tue, Jul 14, 2015 at 02:44:59PM -0400, Cole Robinson wrote:
>> As of fedora polkit-0.113-2, polkit-devel only pulls in polkit-libs, not
>> full polkit, but we need the latter for pkcheck otherwise our configure
>> test fails.
>> ---
>> libvirt.spec.in | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libvirt.spec.in b/libvirt.spec.in
>> index 0adf55e..40d2ccb 100644
>> --- a/libvirt.spec.in
>> +++ b/libvirt.spec.in
>> @@ -531,6 +531,8 @@ BuildRequires: cyrus-sasl-devel
>> %endif
>> %if %{with_polkit}
>> %if 0%{?fedora} >= 20 || 0%{?rhel} >= 7
>> +# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck
>> +BuildRequires: polkit >= 0.112
>> BuildRequires: polkit-devel >= 0.112
>> %else
>> %if 0%{?fedora} || 0%{?rhel} >= 6
>
> NACK.
>
> We don't actually use pkcheck anymore, since we switched to using
> dbus API calls. So we should kill the binary check in configure.ac
> instead.
>
My autotools-fu is weak and I can't really spare time for this at the moment,
so I'd appreciate it if someone else could pick it up
Thanks,
Cole
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list