John Levon <levon@xxxxxxxxxxxxxxxxx> wrote:
> 17) QEMU XML-2-ARGV disk-drive-shared ... FAILED
>
> I have VIR_TEST_DEBUG set, but this is all I get. It's new
The test failure affects all systems, since
two newly required test files were not committed:
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
Obviously, the testing framework should report the failure
to open the .args file:
Here's the patch to do that:
>From 560e27e1576a4c0ebe7db3e697ed9b6d8aa88fbc Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@xxxxxxxxxx>
Date: Fri, 30 Jan 2009 20:06:48 +0100
Subject: [PATCH] tests: diagnose open failure
* tests/qemuxml2argvtest.c (testCompareXMLToArgvFiles): Diagnose
failure to open an input file.
---
tests/qemuxml2argvtest.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 90b4740..1d7aeb9 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -36,8 +36,10 @@ static int testCompareXMLToArgvFiles(const char *xml,
virDomainDefPtr vmdef = NULL;
virDomainObj vm;
- if (virtTestLoadFile(cmd, &expectargv, MAX_FILE) < 0)
+ if (virtTestLoadFile(cmd, &expectargv, MAX_FILE) < 0) {
+ fprintf(stderr, "failed to open %s: %s\n", cmd, strerror (errno));
goto fail;
+ }
if (!(vmdef = virDomainDefParseFile(NULL, driver.caps, xml,
VIR_DOMAIN_XML_INACTIVE)))
--
1.6.1.2.418.gd79e6
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list