Re: [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote:
On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote:
I spend all morning fixing this to be installed properly in the
system.  Anyway, I finally managed to make this work and found out the
guest I used for it is not ready to have multiple monitors.  Anyway,
looking at everything else this definitely works, so ACK, I'll push it
in a while.

I'm still a bit worried that all existing guests will have heads='1' in
their XML as libvirt is adding that by default, but I don't really see a
way around it :-/ We should make sure libvirt stops adding it from now
on though ;)


Well, how would you then limit the outputs to 1?  Having said that, I
have no idea why we started adding heads="1" automatically and playing
with different changes, we have another bug in the parsing/formatting
code.  You'll also won't be able to migrate from older libvirt with
heads='1' to newer ones.  I haven't realized that.  I'm thinking about
reverting the change in libvirt or even using heads > 1.  Although
that won't migrate either.  So the only other thing that we can do is
to introduce new parameter, like maxHeads.  The sound you just heard
is me slapping my face because again there will multiple parameters
meaning similar things...

Christophe

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]