On Thu, Jul 16, 2015 at 04:18:08PM +0200, Peter Krempa wrote: > The scope name, even according to our docs is > "machine-$DRIVER\x2d$VMNAME.scope" virSystemdMakeScopeName would use the > resource partition name instead of "machine-" if it was specified thus > creating invalid scope paths. > > This makes libvirt drop cgroups for a VM that uses custom resource > partition upon reconnecting since the detected scope name would not > match the expected name generated by virSystemdMakeScopeName. > > The error is exposed by the following log entry: > > debug : virCgroupValidateMachineGroup:302 : Name 'machine-qemu\x2dtestvm.scope' for controller 'cpu' does not match 'testvm', 'testvm.libvirt-qemu' or 'machine-test-qemu\x2dtestvm.scope' > > for a "/machine/test" resource and "testvm" vm. This doesn't look right - the whole idea of the resource partition name is that it overrides the default /machine based path. So ignoring the resource partition is not right, unless I'm mis- understanding what this patch is doing. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list