On Tue, Jul 14, 2015 at 16:37:01 +0200, Michal Privoznik wrote:
> There's this condition:
>
> flags & VIR_DOMAIN_AFFECT_CURRENT && virDomainIsActive(dom)
>
> which can never be true since VIR_DOMAIN_AFFECT_CURRENT has hardcoded
> value of zero. Therefore virDomainIsActive() is a dead code. However,
> the condition could make sense if it is rewritten as the following:
>
> !(flags & VIR_DOMAIN_AFFECT_CONFIG) && virDomainIsActive(dom)
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> tools/virsh-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index ac04ded..f7edeeb 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -6499,7 +6499,7 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd)
>
> if (got_vcpu && vcpu >= ncpus) {
> if (flags & VIR_DOMAIN_AFFECT_LIVE ||
> - (flags & VIR_DOMAIN_AFFECT_CURRENT &&
> + (!(flags & VIR_DOMAIN_AFFECT_CONFIG) &&
This still is dead code since VIR_DOMAIN_AFFECT_CONFIG is 0. If you mask
it with any flags you'll get 0, then invert it, it's always true.
Peter
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list