On Fri, Jan 30, 2009 at 11:37:35AM +0000, Daniel P. Berrange wrote:
> diff -r 826e6ed70ee0 src/qemu_driver.c
> --- a/src/qemu_driver.c Fri Jan 30 10:58:34 2009 +0000
> +++ b/src/qemu_driver.c Fri Jan 30 11:00:43 2009 +0000
> @@ -355,10 +355,9 @@ qemudReconnectVMs(struct qemud_driver *d
> qemudLog(QEMUD_ERR, _("Failed to reconnect monitor for %s: %d\n"),
> vm->def->name, rc);
> goto next_error;
> - } else
> - vm->monitorpath = status->monitorpath;
Don't we loose initializing vm->monitorpath on reconnect this way?
The rest of the patch looks fine to me.
-- Guido
> -
> - if((vm->logfile = qemudLogFD(NULL, driver->logDir, vm->def->name)) < 0)
> + }
> +
> + if ((vm->logfile = qemudLogFD(NULL, driver->logDir, vm->def->name)) < 0)
> return -1;
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list