On Tue, 2015-07-07 at 20:26 -0400, John Ferlan wrote: > This series adds/processes a sysfs_prefix for the nodeinfo.c API's. > > Although the nodeinfotest.c passes a local test directory path, it > was > never used. > > This was all brought to light by patch 9 in this series which is > essentially Kothapally Madhu Pavan's v3 patch: > > http://www.redhat.com/archives/libvir-list/2015-June/msg00395.html > > With the adjustment to call nodeGetPresentCPUBitmap and > virNodeParseNode > with the sysfs prefix. > > Without the first 5 patches, the patch as posted caused nodeinfotest > failure in my test environment which doesn't have the "larger" > environments > that the test tried to set up because the test environment used my > present mask file. Patches 1-8 look good to me. Great job splitting the changes in such a nice way! I've commented on patch 7 in a separate mail. I'll look at patch 9 on Monday. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list