On Mon, Jul 06, 2015 at 13:08:35 -0400, John Ferlan wrote:
> Set to ret = -1 and prove otherwise, like usual
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
> src/qemu/qemu_conf.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 80b8926..5ebf2cc 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -1448,7 +1448,7 @@ qemuSetUnprivSGIO(virDomainDeviceDefPtr dev)
> char *sysfs_path = NULL;
> const char *path = NULL;
> int val = -1;
> - int ret = 0;
> + int ret = -1;
>
> /* "sgio" is only valid for block disk; cdrom
> * and floopy disk can have empty source.
> @@ -1467,24 +1467,19 @@ qemuSetUnprivSGIO(virDomainDeviceDefPtr dev)
> if (!qemuIsSharedHostdev(hostdev))
> return 0;
>
> - if (hostdev->source.subsys.u.scsi.sgio) {
> + if (hostdev->source.subsys.u.scsi.sgio)
> virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> _("'sgio' is not supported for SCSI "
> "generic device yet "));
> - ret = -1;
> goto cleanup;
> - }
Wrong removal of the braces.
>
> return 0;
> } else {
> return 0;
> }
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list