On 06/16/2015 03:51 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1072736 > > This series of patches unreverts the functionality from commit id 'ce346623' > which reverted the original functionality. > > Since pure revert caused too many conflicts and because the code has > undergone a few changes since the prior reversion, I had to restore > the code by rote method. The reversion includes some refactorings to > make the final check much easier to handle. Of note patch 3 covers much > of what was adjusted in the reverted patch 'qemuCheckSharedDevice'. > Patch 4 expands the driver lock to cover the same space as the > similar disk code - I can take the other as well and shorten the > time the disk code has the lock. Keeping them similar is mostly a > sanity thing. > > > John Ferlan (7): > qemu: Introduce qemuIsSharedHostdev > qemu: Introduce qemuGetHostdevPath > qemu: Refactor qemuCheckSharedDisk to create virCheckUnprivSGIO > qemu: Refactor qemuAddSharedHostdev and qemuRemoveSharedHostdev > qemu: Extract qemuGetHostdevPath from qemuGetSharedHostdevKey > qemu: Add ability to set sgio values for hostdev > qemu: Add check for unpriv sgio for SCSI generic host device > > src/qemu/qemu_conf.c | 205 ++++++++++++++++++++++++++++++++++----------------- > 1 file changed, 138 insertions(+), 67 deletions(-) > ping... Any thoughts/comments on patches 0.5, 1->5 being "OK" for this upstream release - including squashing part of patch 6 into 1 (thus making patches 6 & 7 downstream only) Tks, John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list