Re: [PATCH 0/4] Some small libxl bug fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 29, 2015 at 11:30:11AM -0600, Jim Fehlig wrote:
> While working on a patch to add dom0 support to the libxl driver,
> I noticed a few existing bugs which are fixed by this small
> series. IMO 1 and 2 are safe even during the freeze as they fix
> quite annoying bugs. 3 and 4 are probably safe bug fixes too,
> unless I'm confused about the use of
> domainObj->{def,newDef,persistentDef}
> 
> Jim Fehlig (4):
>   libxl: don't overwrite domain state from statedir config
>   libxl: don't remove persistent domain on start failure
>   libxl: honor domainGetXMLDesc() --inactive flag
>   libxl: Set def->vcpus after successfully modifying live vcpu count
> 
>  src/libxl/libxl_driver.c | 33 ++++++++++++++++++++++++++-------
>  1 file changed, 26 insertions(+), 7 deletions(-)

  Those looks reasonable to me but 1/ I'm a bit rusty 2/ locking is
hard so even if I ACK this take it with a grain of salt :-)

Daniel

-- 
Daniel Veillard      | Open Source and Standards, Red Hat
veillard@xxxxxxxxxx  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]